Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41255 )
Change subject: src/include/gpio.h: Drop 'include <soc/gpio.h>' ......................................................................
Patch Set 1: Code-Review-2
(1 comment)
Uhh...
https://review.coreboot.org/c/coreboot/+/41255/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41255/1//COMMIT_MSG@9 PS1, Line 9: include <soc/gpio.h> in 'src/include/gpio.h' does not make sense. Uhh... yeah it does, this is intentional. There is a comment literally two lines below the #include you're removing to explain why (and if that's not enough, the commit message where this was added would have gone into more detail).