[coreboot-gerrit] [M] Change in coreboot[main]: mb/google/brox: Fix booting to kernel without battery

[Subrata Banik (Code Review)]

Attention is currently required from: Ashish Kumar Mishra, Caveh Jalali, Dinesh Gehlot, Eric Herrmann, Forest Mittelberg, Jayvik Desai, Kapil Porwal, Karthik Ramasubramanian, Keith Short, Krishna P Bhat D, Nick Vaccaro, Paul Menzel, Rishika Raj, Ronak Kanabar, Shelley Chen, Sowmya Aralguppe, Sowmya Aralguppe.

Subrata Banik has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/83752?usp=email )

Change subject: mb/google/brox: Fix booting to kernel without battery
......................................................................

Patch Set 22:

(1 comment)

File src/mainboard/google/brox/variants/baseboard/brox/ramstage.c:

https://review.coreboot.org/c/coreboot/+/83752/comment/8bc70074_5b7c4a8d?usp... :
PS19, Line 57:  * PL4 calculations - For USB C charger (Max Power):
> Subrata - the boot time increase was not consistently coming in 15:starting LZMA decompress (ignore for x86) -- after starting to load payload
> 1050:finished reading kernel from disk 
> So i could not root cause sorry

I'm unable to follow your statement. If you're saying that boot time has regressed after limiting PL4 at a certain level, then there must be an explanation. Often, we've seen boot time regress because the CPU is operating at low speed, the clock has been reduced, or there's an idle delay. I'm asking you to narrow down the observation by looking at the factors that become prevalent when you limit PL4. Otherwise, this is just another observation without a root cause.