Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Crystal Guo has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85124?usp=email )
Change subject: soc/mediatek/mt8196: Reserve DRAM buffers for HW TX TRACKING
......................................................................
Patch Set 17:
(1 comment)
File src/soc/mediatek/mt8196/dramc_info.c:
https://review.coreboot.org/c/coreboot/+/85124/comment/563bdc2d_1c874263?usp... :
PS17, Line 14: mc->num_entries / CHANNEL_MAX
It's safer to get the number of ranks from `e->rank`.
Is it like this?
for (i = 0; i < mc->num_entries; i++) {
const struct mem_chip_entry *e = &mc->entries[i];
...
rank_count = e->rank + 1;
}
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85124?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I042a74c7fbdc0d3dc19dd6bfd2bf021fe1c2b5fc
Gerrit-Change-Number: 85124
Gerrit-PatchSet: 17
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Crystal Guo
crystal.guo@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Tue, 26 Nov 2024 01:50:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com