Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38003 )
Change subject: mainboard/google/puff: Enable net driver on pcie ep
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38003/5/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/puff/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/38003/5/src/mainboard/google/hatch/...
PS5, Line 183: chip drivers/net
: register "customized_leds" = "0x05af"
: device pci 00.0 on end
: end
What is https://review.coreboot.org/c/coreboot/+/36651 all about? Looks unfinished currently?
It is expected to enable support for devicetree update when root ports get swapped by FSP such that the mainboard can continue adding chips/devices to the root port on which the devices really live on. Having that change in will enable you to add this chip and device for NIC under 1c.6 instead of adding it to 1c.0.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38003
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I76ce6d8a5a26842fcb2544ee96567fe0da8603b1
Gerrit-Change-Number: 38003
Gerrit-PatchSet: 5
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 18 Jan 2020 08:17:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment