Attention is currently required from: Martin Roth, Tim Wawrzynczak, Subrata Banik, Balaji Manigandan, Aamir Bohra.
V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49732 )
Change subject: mb/intel/shadowmountain: Add the ramstage code
......................................................................
Patch Set 5:
(3 comments)
Patchset:
PS5:
a
File src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/49732/comment/9c5cec86_53684088
PS4, Line 38:
remove
Done
File src/mainboard/intel/shadowmountain/variants/baseboard/early_gpio.c:
https://review.coreboot.org/c/coreboot/+/49732/comment/f4afe4b6_ced96277
PS4, Line 22:
remove this.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49732
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I419eecefddf9ee6e4249ada041ebeb1b78e85eb7
Gerrit-Change-Number: 49732
Gerrit-PatchSet: 5
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Comment-Date: Fri, 19 Feb 2021 01:10:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment