Attention is currently required from: Shelley Chen, Julius Werner, Xixi Chen, Yu-Ping Wu.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68871 )
Change subject: mem_chip_info: Update to new format ......................................................................
Patch Set 3:
(3 comments)
File src/soc/mediatek/common/memory.c:
https://review.coreboot.org/c/coreboot/+/68871/comment/11129413_24702c00 PS3, Line 125: entry The entry pointer seems never gets updated?
https://review.coreboot.org/c/coreboot/+/68871/comment/ac48e065_29e47638 PS3, Line 150: size = sizeof(*mc) + : sizeof(struct mem_chip_entry) * CHANNEL_MAX * curr_ddr_info->mrr_info.rank_nums; Is it possible to refactor mem_chip_info_size() to take a 'entries' parameter so both MTK and QC can use that function for size calculation? e.g.,
size_t mem_chip_info_size(int entries);
https://review.coreboot.org/c/coreboot/+/68871/comment/91e8bb3f_0fd8cba6 PS3, Line 155: fill_dram_info can we do memset(mc, 0, size) first so there's no need to do reserve[0] = 0, reserve[1] = 0 in the fill_dram_info?