Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33485 )
Change subject: mainboard/google/hatch: Scrub Helios GPIOs ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/#/c/33485/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/helios/gpio.c:
https://review.coreboot.org/#/c/33485/2/src/mainboard/google/hatch/variants/... PS2, Line 31: 1 This should eventually be de-asserted in ACPI _ON routine so that the power on timings are not violated. We can leave it here for now.
https://review.coreboot.org/#/c/33485/2/src/mainboard/google/hatch/variants/... PS2, Line 31: UP_20K Why is the pull-up required?
https://review.coreboot.org/#/c/33485/2/src/mainboard/google/hatch/variants/... PS2, Line 33: UP_20K Why is internal pull-up required if we are actively driving it?
https://review.coreboot.org/#/c/33485/2/src/mainboard/google/hatch/variants/... PS2, Line 75: DN_20K Why PD?