Attention is currently required from: Maulik V Vaghela, Paul Menzel, Tim Wawrzynczak.
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56882 )
Change subject: mb/google/brya: Configure A17 GPIO to high
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56882/comment/ca1fcf5f_e7e87e53
PS2, Line 7: Update A17 GPIO for USB UFC power
Maybe: Configure USB UFC voltage to 3. […]
Updated the commit msg to better explain the change
https://review.coreboot.org/c/coreboot/+/56882/comment/c6e33e39_2e0fc89a
PS2, Line 9: A17 enables the 3.3V to UFC
What voltage is currently used (default)?
Updated the commit msg to better explain the change
https://review.coreboot.org/c/coreboot/+/56882/comment/cdb1ae5b_d3bc8fd6
PS2, Line 10:
Please elaborate, why you are basically reverting https://review.coreboot.org/c/coreboot/+/56655.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56882
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88c204ec07b1f7511f0d88074e336cfc9116a7d2
Gerrit-Change-Number: 56882
Gerrit-PatchSet: 3
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sanju Jose Thottan
sanjujose.thottan@intel.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Comment-Date: Wed, 11 Aug 2021 17:05:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment