Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31781 )
Change subject: src: Drop unused 'include <arch/acpigen.h>' ......................................................................
Patch Set 7: Code-Review+1
(8 comments)
https://review.coreboot.org/#/c/31781/7/src/mainboard/bap/ode_e20XX/acpi_tab... File src/mainboard/bap/ode_e20XX/acpi_tables.c:
https://review.coreboot.org/#/c/31781/7/src/mainboard/bap/ode_e20XX/acpi_tab... PS7, Line 20: In other files you have removed the extra newlines. Why not here?
https://review.coreboot.org/#/c/31781/7/src/mainboard/biostar/a68n_5200/acpi... File src/mainboard/biostar/a68n_5200/acpi_tables.c:
https://review.coreboot.org/#/c/31781/7/src/mainboard/biostar/a68n_5200/acpi... PS7, Line 20: Same here
https://review.coreboot.org/#/c/31781/7/src/mainboard/biostar/am1ml/acpi_tab... File src/mainboard/biostar/am1ml/acpi_tables.c:
https://review.coreboot.org/#/c/31781/7/src/mainboard/biostar/am1ml/acpi_tab... PS7, Line 21: and here
https://review.coreboot.org/#/c/31781/7/src/mainboard/elmex/pcm205400/acpi_t... File src/mainboard/elmex/pcm205400/acpi_tables.c:
https://review.coreboot.org/#/c/31781/7/src/mainboard/elmex/pcm205400/acpi_t... PS7, Line 21: and here
https://review.coreboot.org/#/c/31781/7/src/mainboard/gizmosphere/gizmo2/acp... File src/mainboard/gizmosphere/gizmo2/acpi_tables.c:
https://review.coreboot.org/#/c/31781/7/src/mainboard/gizmosphere/gizmo2/acp... PS7, Line 20: here again
https://review.coreboot.org/#/c/31781/7/src/mainboard/google/jecht/acpi_tabl... File src/mainboard/google/jecht/acpi_tables.c:
https://review.coreboot.org/#/c/31781/7/src/mainboard/google/jecht/acpi_tabl... PS7, Line 26: here, too
https://review.coreboot.org/#/c/31781/7/src/mainboard/hp/abm/acpi_tables.c File src/mainboard/hp/abm/acpi_tables.c:
https://review.coreboot.org/#/c/31781/7/src/mainboard/hp/abm/acpi_tables.c@2... PS7, Line 21: same here
https://review.coreboot.org/#/c/31781/7/src/mainboard/pcengines/apu1/acpi_ta... File src/mainboard/pcengines/apu1/acpi_tables.c:
https://review.coreboot.org/#/c/31781/7/src/mainboard/pcengines/apu1/acpi_ta... PS7, Line 20: same