Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid
......................................................................
Patch Set 51:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44272/50/src/mainboard/google/volte...
File src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt:
https://review.coreboot.org/c/coreboot/+/44272/50/src/mainboard/google/volte...
PS50, Line 2: H5AN8G6NDJR-XNC 0 (0000)
: MT40A512M16TB-062E:J 1 (0001)
: H5ANAG6NCMR-XNC 2 (0010)
Done
Didn't the ODM already have a build using IDs 0,1 and 2? Wouldn't it create a problem if the IDs are now changed?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44272
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66
Gerrit-Change-Number: 44272
Gerrit-PatchSet: 51
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mice Lin
mice_lin@wistron.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 25 Aug 2020 03:23:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment