Attention is currently required from: Krystian Hebel, Timothy Pearson, Ron Minnich.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57084 )
Change subject: src/arch/ppc64/*: pass FDT address to payload
......................................................................
Patch Set 20:
(2 comments)
File src/arch/ppc64/boot.c:
https://review.coreboot.org/c/coreboot/+/57084/comment/e833b518_d54f5103
PS20, Line 42: asm("ld 27,%0" :: "m"(fdt) : "27");
Only QEMU prepares FDT in advance, real hardware doesn't, so all of the new code should be moved to […]
Done
File src/arch/ppc64/bootblock_crt0.S:
https://review.coreboot.org/c/coreboot/+/57084/comment/da1b7dc5_2e7a3ca1
PS20, Line 40: /* Store FDT address that's available in %r3 to pass to payload */
Maybe use one of SPRs for holding this value so it won't have to be moved around in RAM? HSPRG0 or H […]
Used HSPRG0. This significantly simplified this change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57084
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0911f4b534c6f8cacfa057a5bad7576fec711637
Gerrit-Change-Number: 57084
Gerrit-PatchSet: 20
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Ron Minnich
rminnich@gmail.com
Gerrit-Reviewer: Timothy Pearson
tpearson@raptorengineering.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Timothy Pearson
tpearson@raptorengineering.com
Gerrit-Attention: Ron Minnich
rminnich@gmail.com
Gerrit-Comment-Date: Fri, 26 Nov 2021 21:41:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-MessageType: comment