12 Nov
2019
12 Nov
'19
4:58 a.m.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36662 )
Change subject: arch/x86: Correctly determine number of enabled cores ......................................................................
Patch Set 2: Code-Review+1
Taking into account what Arthur said, PS2 looks good. There should probably be a sanity check elsewhere to ensure CONFIG_MAX_CPUS isn't exceeded. As far as SMBIOS tables are concerned using the MIN rather than MAX here seems correct.
--
To view, visit https://review.coreboot.org/c/coreboot/+/36662
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id0935f48e73c037bb7c0e1cf36f94d98a40a499c
Gerrit-Change-Number: 36662
Gerrit-PatchSet: 2
Gerrit-Owner: Andrey Petrov anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 12 Nov 2019 03:58:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment