Attention is currently required from: Furquan Shaikh, Aseda Aboagye, Karthik Ramasubramanian. Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52147 )
Change subject: soc/intel/jasperlake: Move HECI_DISABLE_USING_SMM to mainboards ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/52147/comment/74d89153_136f5eed PS1, Line 38: HECI_DISABLE_USING_SMM
I did not understand the plan is to drop CONFIG(HECI_DISABLE_USING_SMM) check in smihandler.c too. […]
I must have misunderstood your previous comment then.
We'll need to remove the following:
src/soc/intel/common/block/cse/Kconfig:config SOC_INTEL_COMMON_BLOCK_HECI_DISABLE_IN_SMM
And always add this to SMM. src/soc/intel/common/block/cse/Makefile.inc:smm-$(CONFIG_SOC_INTEL_COMMON_BLOCK_HECI_DISABLE_IN_SMM) += disable_heci.c
In addition, we'll need to remove all the HECI_DISABLE_USING_SMM options from all the existing paths as well to make that happen properly.
Aseda, do you want to give that a go? We'll have to do a few CLs. Let me know if you want me to do that.