Daniel Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45058 )
Change subject: mb/google/volteer: Change default camera power GPIO to 0
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45058/1/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/volteer/gpio.c:
https://review.coreboot.org/c/coreboot/+/45058/1/src/mainboard/google/voltee...
PS1, Line 129: RCAM_RST_L
should we assert reset as well? […]
The comment is not right anymore. RCAM_RST_L(F15) was assigned for the rear camera reset in the previous version of the HW. But now they changed to share the same D4 for both rear and front camera reset. And D4 is set as assert reset.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45058
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic7df391aa512daafe6e1ce49e9222b90e17ad806
Gerrit-Change-Number: 45058
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kang
daniel.h.kang@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Bingbu Cao
bingbu.cao@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel H Kang
daniel.h.kang@intel.corp-partner.google.com
Gerrit-Comment-Date: Mon, 14 Sep 2020 23:42:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Gerrit-MessageType: comment