Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43678 )
Change subject: soc/amd/picasso: Don't run dcache_clean_all() in psp_verstage
......................................................................
Patch Set 4: Code-Review+1
I don't like adding weak functions very much, but a relatively generic Kconfig option can't be just only set in the verstage on PSP case and not for the rest of corebooot for picasso, linking cache_m.c instead of cpu.S in the verstage on psp case is semantically incorrect and having an oddly specific Kconfig option isn't great either.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43678
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6775b2e049d6cfd9f78f2e07a941f6cc5be254b8
Gerrit-Change-Number: 43678
Gerrit-PatchSet: 4
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 23 Jul 2020 16:02:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment