[coreboot-gerrit] [L] Change in coreboot[main]: mb/asrock: Add Z87E-ITX (Haswell)

[Angel Pons (Code Review)]

Attention is currently required from: Máté Kukri, Nicholas Chin.

Angel Pons has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/81022?usp=email )

Change subject: mb/asrock: Add Z87E-ITX (Haswell)
......................................................................

Patch Set 3:

(4 comments)

File src/mainboard/asrock/z87e-itx/gma-mainboard.ads:

https://review.coreboot.org/c/coreboot/+/81022/comment/26d516b0_0fa55f44?usp... :
PS3, Line 12: DP1,
            :       DP2,
            :       DP3,
> Only one of these is actually needed. […]

DP2 is DP, HDMI2 is DP alt mode (I'm not sure if it's supported, but keeping HDMI2 enabled won't hurt)

Looks like it matches https://review.coreboot.org/c/coreboot/+/68188/11/src/mainboard/asrock/z97_e...

https://review.coreboot.org/c/coreboot/+/81022/comment/43057936_ec8dd48b?usp... :
PS3, Line 15:       HDMI1,
HDMI1 is DVI

https://review.coreboot.org/c/coreboot/+/81022/comment/fce4fc7a_e469a6de?usp... :
PS3, Line 17:       HDMI3,
HDMI3 is HDMI

https://review.coreboot.org/c/coreboot/+/81022/comment/f6403a23_a8f6f524?usp... :
PS3, Line 18:       Analog,
Analog is also DVI (it's DVI-D)