Attention is currently required from: Martin L Roth.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68926 )
Change subject: commonlib...cbmem_id.h: Add AMD STB buffer IDs for CBMEM ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h:
https://review.coreboot.org/c/coreboot/+/68926/comment/b929013e_2c6de610 PS1, Line 164: { CBMEM_ID_AMD_STB, "AMD MP2 BUFFER"} nit: Should this have a blank line before the #endif?
nit: Would it break anything if there is a comma at the end of this line? That way fewer lines would change in the future when more IDs are added.