Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48248 )
Change subject: soc/intel/xeon_sp: Use common block ACPI ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48248/8/src/soc/intel/xeon_sp/acpi.... File src/soc/intel/xeon_sp/acpi.c:
https://review.coreboot.org/c/coreboot/+/48248/8/src/soc/intel/xeon_sp/acpi.... PS8, Line 99: add_madt_ioapic
IIUC, the major difference between the common ACPI implementation of this function and the SoC-speci […]
This could be fine. Moved the discussion to https://review.coreboot.org/c/coreboot/+/48246 where the callback/override change discussion is.