Attention is currently required from: Kevin Chiu, Paul Menzel, Tim Wawrzynczak, Nick Vaccaro, Wisley Chen.
Shon Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59305 )
Change subject: mb/google/brya/var/vell: update gpio override
......................................................................
Patch Set 17:
(3 comments)
File src/mainboard/google/brya/variants/vell/gpio.c:
https://review.coreboot.org/c/coreboot/+/59305/comment/46cbb39c_2947faef
PS15, Line 13: PAD_CFG_NF(GPP_A14, NONE, DEEP, NF1),
no need for this, already set as such in brya baseboard gpio. […]
Done
https://review.coreboot.org/c/coreboot/+/59305/comment/6c37ae9a_cd32760c
PS15, Line 45: PAD_CFG_GPI(GPP_E17, NONE, DEEP),
no need for this, already set as such in brya baseboard gpio. […]
Done
https://review.coreboot.org/c/coreboot/+/59305/comment/fe95ce9c_36a6a35c
PS15, Line 90: PAD_CFG_NF(GPD1, NONE, DEEP, NF1),
no need for this, already set as such in brya baseboard gpio. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59305
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc91866f7555c294af7eed9e5d1550e73d8059d0
Gerrit-Change-Number: 59305
Gerrit-PatchSet: 17
Gerrit-Owner: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Attention: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Comment-Date: Fri, 10 Dec 2021 11:21:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment