Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35555 )
Change subject: mediatek/mt8183: Save multiple frequency calibration result to shuffle ......................................................................
Patch Set 3:
(4 comments)
Style fixes should not be mixed into functional changes.
https://review.coreboot.org/c/coreboot/+/35555/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35555/3//COMMIT_MSG@9 PS3, Line 9: frequency frequencies
https://review.coreboot.org/c/coreboot/+/35555/3//COMMIT_MSG@9 PS3, Line 9: shuffle What does *shuffle* mean in this context?
https://review.coreboot.org/c/coreboot/+/35555/3/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_init_setting.c:
https://review.coreboot.org/c/coreboot/+/35555/3/src/soc/mediatek/mt8183/dra... PS3, Line 69: u8 Just use `unsigned int` or `int`?
https://review.coreboot.org/c/coreboot/+/35555/3/src/soc/mediatek/mt8183/dra... PS3, Line 123: clrbits_le32(&ch[chn].phy.shu[0].pll[4], 0xffff); Please factor out the style fixes (also below) into a separate commit.