Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35634 )
Change subject: vboot: create board-specific test-only GBB HWID if not set ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35634/3/src/security/vboot/Makefile... File src/security/vboot/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35634/3/src/security/vboot/Makefile... PS3, Line 244: util/chromeos/gen_test_hwid.sh shouldn't this be $(top)/util/...
https://review.coreboot.org/c/coreboot/+/35634/1/src/security/vboot/gen_hwid... File src/security/vboot/gen_hwid.sh:
https://review.coreboot.org/c/coreboot/+/35634/1/src/security/vboot/gen_hwid... PS1, Line 38: crc="$(python -c "import zlib, sys; sys.stdout.write(\
b) Add an option in gbb_utility to say append CRC32 to HWID. […]
SGTM.