Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Sridhar Siricilla, Patrick Rudolph.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62560 )
Change subject: soc/intel/common: Retry MEI CSE DISABLE command
......................................................................
Patch Set 4:
(3 comments)
File src/soc/intel/common/block/cse/cse_eop.c:
https://review.coreboot.org/c/coreboot/+/62560/comment/3fb826d5_2b3fe523
PS3, Line 14: MAX_RETRY_EOP_MSG
Hmm :) I don't think this will be required!
Done
https://review.coreboot.org/c/coreboot/+/62560/comment/2db5efa9_97e4d631
PS3, Line 31: decode_heci_send_receive_error
Since EOP command handler returns cse_eop_result type enum values while CSE DISABLE command handler […]
Done
https://review.coreboot.org/c/coreboot/+/62560/comment/10802713_f448d408
PS3, Line 77: cse_send_bus_disable_message
See above reason. Both handlers use own enum values, so APIs return different enum type values. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62560
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id38a172d670a0cd44643744f27b85ca7e368ccdb
Gerrit-Change-Number: 62560
Gerrit-PatchSet: 4
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sridhar Siricilla
sridhar.nest@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 09 Mar 2022 11:00:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment