Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/71854 )
Change subject: mb/google/skyrim/var/winterhold: Update USB port A0 setting ......................................................................
mb/google/skyrim/var/winterhold: Update USB port A0 setting
Update USB port Type-A Port A0 setting.
BUG=b:261650602 TEST=emerge-skyrim coreboot. Ensure that USB-A port is enumerated correctly in the output of lusub command.
Change-Id: I9563f7b141c34b613cf896f1ce92178617a62c93 Signed-off-by: EricKY Cheng ericky_cheng@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/71854 Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Van Patten timvp@google.com --- M src/mainboard/google/skyrim/variants/winterhold/overridetree.cb 1 file changed, 31 insertions(+), 43 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Van Patten: Looks good to me, approved Eric Lai: Looks good to me, approved
diff --git a/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb b/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb index f0dfecc9..04da26c 100644 --- a/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb +++ b/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb @@ -133,54 +133,23 @@ device ref xhci_1_root_hub on # XHCI1 root hub chip drivers/usb/acpi device ref usb3_port3 on # USB 3.1 port3 - chip drivers/usb/hub - register "desc" = ""USB Hub"" - register "name" = ""VL822"" - register "port_count" = "4" - device usb 0.0 on # VL822 USB3 hub - chip drivers/usb/acpi - register "desc" = ""USB3 Type-A Port A0 (DB)"" - register "type" = "UPC_TYPE_USB3_A" - register "use_custom_pld" = "true" - register "custom_pld" = "ACPI_PLD_TYPE_A(LEFT, RIGHT, ACPI_PLD_GROUP(2, 2))" - device usb 3.0 on end - end - chip drivers/usb/acpi - register "desc" = ""WWAN"" - register "type" = "UPC_TYPE_INTERNAL" - register "group" = "ACPI_PLD_GROUP(2, 2)" - register "has_power_resource" = "1" - register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_42)" - register "reset_off_delay_ms" = "20" - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_8)" - register "enable_delay_ms" = "20" - device usb 3.1 on end - end - end # VL822 USB3 hub + chip drivers/usb/acpi + register "desc" = ""USB3 Type-A Port A0 (MLB)"" + register "type" = "UPC_TYPE_USB3_A" + register "use_custom_pld" = "true" + register "custom_pld" = "ACPI_PLD_TYPE_A(LEFT, LEFT, ACPI_PLD_GROUP(3, 1))" + device usb 3.2 on end end end # USB 3.1 port3 end chip drivers/usb/acpi device ref usb2_port3 on # USB 2 port3 - chip drivers/usb/hub - register "desc" = ""USB Hub"" - register "name" = ""VL822"" - register "port_count" = "4" - device usb 0.0 on # VL822 USB2 hub - chip drivers/usb/acpi - register "desc" = ""USB2 Type-A Port A0 (DB)"" - register "type" = "UPC_TYPE_USB3_A" - register "use_custom_pld" = "true" - register "custom_pld" = "ACPI_PLD_TYPE_A(LEFT, RIGHT, ACPI_PLD_GROUP(2, 2))" - device usb 2.0 on end - end - chip drivers/usb/acpi - register "desc" = ""WWAN"" - register "type" = "UPC_TYPE_INTERNAL" - register "group" = "ACPI_PLD_GROUP(2, 2)" - device usb 2.1 on end - end - end # VL822 USB2 hub + chip drivers/usb/acpi + register "desc" = ""USB2 Type-A Port A0 (MLB)"" + register "type" = "UPC_TYPE_USB3_A" + register "use_custom_pld" = "true" + register "custom_pld" = "ACPI_PLD_TYPE_A(LEFT, LEFT, ACPI_PLD_GROUP(3, 1))" + device usb 2.2 on end end end # USB 2 port3 end