Attention is currently required from: Ferass EL HAFIDI, Arthur Heymans, Evgeny Zinoviev.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63587 )
Change subject: apple/macbook21: configure the clockgen and add C3 CPU state
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
Patchset:
PS4:
i'd probably split the patch into the clock generator config and adding the c3 state as separate second patch, but i don't see much of a problem with having both in one patch either, since the scope is still small enough.
File src/mainboard/apple/macbook21/cstates.c:
https://review.coreboot.org/c/coreboot/+/63587/comment/95b76b2b_857a6f2a
PS4, Line 34: .latency = 17,
is this the latency value from the vendor firmware's ACPI?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63587
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib97f95599fbdf66aa55e936bdcb9cc0cd69b3824
Gerrit-Change-Number: 63587
Gerrit-PatchSet: 4
Gerrit-Owner: Ferass EL HAFIDI
vitali64pmemail@protonmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ferass EL HAFIDI
vitali64pmemail@protonmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Evgeny Zinoviev
me@ch1p.io
Gerrit-Comment-Date: Thu, 14 Apr 2022 16:34:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment