Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41247 )
Change subject: soc/amd/common/block/lpc: Add lpc_initialize_spi_bar()
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41247/1/src/soc/amd/common/block/in...
File src/soc/amd/common/block/include/amdblocks/lpc.h:
https://review.coreboot.org/c/coreboot/+/41247/1/src/soc/amd/common/block/in...
PS1, Line 191: * Initializes SPI base addres register which includes the following two components:
'addres' may be misspelled - perhaps 'address'?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41247
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f270ba1745b4bb8a403f00cd069a02e21d444be
Gerrit-Change-Number: 41247
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 11 May 2020 18:47:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment