Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84026?usp=email )
Change subject: soc/mediatek/mt8196: Add EINT support ......................................................................
Patch Set 12:
(4 comments)
File src/soc/mediatek/mt8196/eint.c:
PS7:
rename to gpio_eint.c for consistency.
Done
File src/soc/mediatek/mt8196/eint.c:
https://review.coreboot.org/c/coreboot/+/84026/comment/e8d9d038_7ce1dbd9?usp... : PS8, Line 11: [4]
If we're using `uint8_t` for `instance`, please define enum for its values (e.g. […]
Use `define` instead of `enum` since `enum` data size is 4 bytes.
https://review.coreboot.org/c/coreboot/+/84026/comment/fe20a0d4_272afe9a?usp... : PS8, Line 11: uint32_t
We only use EINT to setup the IRQ pin from GSC. […]
Done
https://review.coreboot.org/c/coreboot/+/84026/comment/3834e651_4c5aaad8?usp... : PS8, Line 13: {0, 2, 0, 1},
Can we put one entry `{a, b, c, d}` per line?
Done