Attention is currently required from: Andrey Petrov, Angel Pons, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun.
Jayvik Desai has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/83769?usp=email )
Change subject: soc/intel/mtl: enable FSP uGOP config in MTL for eSOL ......................................................................
Patch Set 12:
(10 comments)
Patchset:
PS1:
split this into two cls […]
Created the CL's.
Patchset:
PS2:
this CL should be the base CL IMO.
Yes agreed
Commit Message:
https://review.coreboot.org/c/coreboot/+/83769/comment/ece05ccb_94929226?usp... : PS9, Line 9: This patch enables the FSP uGOP eSOL feature for meteorlake SOC
Please inform that you are replacing the earlier config with a more generic uGOP config. […]
Updated in patchset#12
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/83769/comment/c6dda008_ebcd783e?usp... : PS1, Line 463: help
Added
https://review.coreboot.org/c/coreboot/+/83769/comment/6114ceb0_e287d9b1?usp... : PS1, Line 464: Enable the FSP-M Sign-of-Life feature to display a : configurable text message on screen during memory training : and CSME update.
you didn't mention the underlying technology (uGOP) that Intel uses to enable eSOL as part of FSP-M
Acknowledged
https://review.coreboot.org/c/coreboot/+/83769/comment/10526a52_1dbdf9c5?usp... : PS1, Line 468:
empty line
Removed
File src/soc/intel/meteorlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/83769/comment/d0dfa141_9ad5621c?usp... : PS1, Line 25: select VBT_CBFS_COMPRESSION_DEFAULT_LZ4 if FSP_UGOP_EARLY_SIGN_OF_LIFE
please follow order
Acknowledged
File src/soc/intel/meteorlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/83769/comment/8277f514_dd363bd9?usp... : PS2, Line 25: select VBT_CBFS_COMPRESSION_DEFAULT_LZ4 if FSP_UGOP_EARLY_SIGN_OF_LIFE @subratabanik@google.com, Can you please suggest a proper way to select this config ?
File src/soc/intel/meteorlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/83769/comment/2eaf79e6_73a520c4?usp... : PS8, Line 23: select FSP_USES_CB_DEBUG_EVENT_HANDLER : select FSP_UGOP_EARLY_SIGN_OF_LIFE if !SOC_INTEL_METEORLAKE_PRE_PRODUCTION_SILICON
Rewrote in alphabetical order
https://review.coreboot.org/c/coreboot/+/83769/comment/7b22267c_dbddda89?usp... : PS8, Line 24: FSP_UGOP_EARLY_SIGN_OF_LIFE
move after line 22
Fixed in patch set-9.