Attention is currently required from: Kevin Chiu, Tim Wawrzynczak, Wisley Chen, Shon Wang.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59305 )
Change subject: mb/google/brya/var/vell: update gpio override
......................................................................
Patch Set 15:
(3 comments)
File src/mainboard/google/brya/variants/vell/gpio.c:
https://review.coreboot.org/c/coreboot/+/59305/comment/06d8c4cf_91b97c7a
PS15, Line 13: PAD_CFG_NF(GPP_A14, NONE, DEEP, NF1),
no need for this, already set as such in brya baseboard gpio.c
https://review.coreboot.org/c/coreboot/+/59305/comment/a0380a63_f985d945
PS15, Line 45: PAD_CFG_GPI(GPP_E17, NONE, DEEP),
no need for this, already set as such in brya baseboard gpio.c
https://review.coreboot.org/c/coreboot/+/59305/comment/061f5ce6_cd4aafb8
PS15, Line 90: PAD_CFG_NF(GPD1, NONE, DEEP, NF1),
no need for this, already set as such in brya baseboard gpio.c
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59305
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc91866f7555c294af7eed9e5d1550e73d8059d0
Gerrit-Change-Number: 59305
Gerrit-PatchSet: 15
Gerrit-Owner: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Attention: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Attention: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 06 Dec 2021 19:10:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment