Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31519 )
Change subject: mediatek/mt8183: Modify I2C source clock
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31519/1/src/soc/mediatek/mt8183/pll.c
File src/soc/mediatek/mt8183/pll.c:
https://review.coreboot.org/#/c/31519/1/src/soc/mediatek/mt8183/pll.c@349
PS1, Line 349: 0x1 << 11
I just modeled the above code. […]
Please modify that, although not necessary to be macro def.
It can be anything that in code: simply explain the value in comment or macro def or enum.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31519
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I49e0acda22dba449d0873a95ba5fae79a9cef569
Gerrit-Change-Number: 31519
Gerrit-PatchSet: 1
Gerrit-Owner: wang qii
Qii.Wang@mediatek.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: wang qii
Qii.Wang@mediatek.com
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-Comment-Date: Fri, 22 Feb 2019 03:49:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: wang qii
Qii.Wang@mediatek.com
Gerrit-MessageType: comment