Attention is currently required from: Bora Guvendik, Hannah Williams, Dinesh Gehlot, Jay Patel.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72931 )
Change subject: soc/intel/cmn/blk: Request pre-reset EC boot timestamps
......................................................................
Patch Set 14:
(1 comment)
File src/soc/intel/common/block/ec_telemetry/ec_telemetry.c:
https://review.coreboot.org/c/coreboot/+/72931/comment/d6dc015b_7416ffb1
PS14, Line 39: /*
: cnt increments on every warm reboot and reset to 0 on cold reboot. Therefore, cold
: reboot timestamp will not be a part of cbmem TS table after warm reboot
: */
we are not following basic coding style, wondering how this CL ended up with +2?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72931
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iecb88eaa085759ea9430708d45abf1ca69727ce9
Gerrit-Change-Number: 72931
Gerrit-PatchSet: 14
Gerrit-Owner: Jay Patel
jay2.patel@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dinesh Gehlot
digehlot@google.com
Gerrit-CC: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Jay Patel
jay2.patel@intel.com
Gerrit-Comment-Date: Wed, 19 Apr 2023 03:30:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment