Attention is currently required from: Jason Glenesk, Raul Rangel, EricKY Cheng, Matt DeVillier, Nelson Ye, Tim Van Patten, Eric Peers, Fred Reitberger, Karthikeyan Ramasubramanian, Felix Held.
Chris Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68470 )
Change subject: soc/amd/acpi: Expand 5 DPTC thermal profiles acpigen support for Alib
......................................................................
Patch Set 14:
(1 comment)
File src/soc/amd/common/block/include/amdblocks/alib.h:
https://review.coreboot.org/c/coreboot/+/68470/comment/db3f82c5_cfd74917
PS12, Line 24: ALIB_DPTC_STT_MIN_LIMIT_ID = 0x20,
: ALIB_DPTC_STT_M1_ID = 0x21,
: ALIB_DPTC_STT_M2_ID = 0x22,
: ALIB_DPTC_STT_C_APU_ID = 0x23,
: ALIB_DPTC_STT_SKIN_TEMPERATURE_LIMIT_APU_ID = 0x24,
: ALIB_DPTC_STT_ALPHA_APU_ID = 0x25,
: ALIB_DPTC_STT_ERROR_COEFF_ID = 0x26,
: ALIB_DPTC_STT_ERROR_RATE_COEFF_ID = 0x27,
These values don't match "AMD Generic Encapsulated Software Architecture (AGESATM) Interface Specifi […]
Hi Tim,
Yes, we can validate the value via agt command, you can read back the value by `agt -i=2 -SttM1Coeff` for example, and you can find the parameters with `agt dptc` to check.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68470
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e6d5c0fc6f492340c935899920d9ee7c9396256
Gerrit-Change-Number: 68470
Gerrit-PatchSet: 14
Gerrit-Owner: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nelson Ye
nelson_ye@compal.corp-partner.google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Nelson Ye
nelson_ye@compal.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Eric Peers
epeers@google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 31 Oct 2022 07:38:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment