Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34285 )
Change subject: soc/intel: Fix regression with hidden PCI devices
......................................................................
Patch Set 3:
Patch Set 3:
Patch Set 2:
Not tested, Maxim ?
Thanks for this patch. Now it works well
I can see such devices in the console:
$ grep -rn "BUG:" 34285-console.log
34:BUG: soc_peg_init_params requests hidden 00:01.1
35:BUG: soc_peg_init_params requests hidden 00:01.2
OK. While annoying, I think this is better than reverting the offending commit?
With the output here I think it is easy to track down the cases where we would try to access PCI devices that would not respond to configuration cycles.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34285
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5eab3e7f1993b686103eaa257aacda379dc259fa
Gerrit-Change-Number: 34285
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 12 Jul 2019 14:07:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment