Attention is currently required from: Dinesh Gehlot, Elyes Haouas, Eran Mitrani, Eric Lai, Jakub Czapiga, Kapil Porwal, Marvin Evers, Michael Strosche, Subrata Banik, Tarun, Tarun Tuli.
Felix Singer has posted comments on this change by Michael Strosche. ( https://review.coreboot.org/c/coreboot/+/77374?usp=email )
Change subject: soc/intel/meteorlake/chip.h: Use boolean type where applicable
......................................................................
Patch Set 9:
(6 comments)
File src/soc/intel/meteorlake/chip.h:
https://review.coreboot.org/c/coreboot/+/77374/comment/47d20793_1e729792?usp... :
PS8, Line 212: 1:Enable, 0:Disable
update the comment
Done
https://review.coreboot.org/c/coreboot/+/77374/comment/cd3eda68_0ef83dbc?usp... :
PS8, Line 235: * Default 0. Setting this to 1 disables
update
Done
https://review.coreboot.org/c/coreboot/+/77374/comment/533a9263_542d3a52?usp... :
PS8, Line 301: 1b:Enabled, 0b:Disabled
update
Done
https://review.coreboot.org/c/coreboot/+/77374/comment/6d86a64c_b791207a?usp... :
PS8, Line 451: Default 0. Setting this to 1 disables th
update
Done
https://review.coreboot.org/c/coreboot/+/77374/comment/cc7eb879_83ac0ab4?usp... :
PS8, Line 456: Enable(1)/Disable(0)
update
Done
https://review.coreboot.org/c/coreboot/+/77374/comment/55e8a9f3_b40a3aca?usp... :
PS8, Line 457: Default 0. Setting this to 1
update
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77374?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I15dfd5ed0541352930c3b70252b3e536ad1e6efd
Gerrit-Change-Number: 77374
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Strosche
michael.strosche@gmail.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Marvin Evers
marvin.n.evers@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Marvin Evers
marvin.n.evers@gmail.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Michael Strosche
michael.strosche@gmail.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Mon, 12 Aug 2024 02:20:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr