Attention is currently required from: Mario Scheithauer, Werner Zeh.
Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74628 )
Change subject: mb/siemens/mc_ehl4: Adjust GPIOs ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3: I might suggest mentioning also the GPIOs that have a default value or are NC.
Because when we rely on defaults that have to be looked up in some documentation, we have this information scattered around two places. It's not even clear at the first sight, whether all non-mentioned pins are set as NC or have some other default - this already managed to confuse me during the review.
From my point of view, it would be nice to keep the information about every relevant pin in the code, as we did on APL. This might be a case for our other EHL boards.