Attention is currently required from: Kapil Porwal, Rui Zhou, Tarun Tuli.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75832?usp=email )
Change subject: mb/google/rex/var/screebo: rp2 change to rp1 and rp3
......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/rex/variants/screebo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/75832/comment/a44c747f_dc3b33f4 :
PS1, Line 245: device ref tbt_pcie_rp1 on end
: device ref tbt_pcie_rp3 on end
i thought screebo has two type-c ports as tbt_pcie_rp1 and tbt_pcie_rp3
are you making tbt_pcie_rp0 (0: 7.0) being enabled for PCI multiple function device to be enabled ?
https://review.coreboot.org/c/coreboot/+/75832/comment/0e088062_fff35689 :
PS1, Line 246:
use tab
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75832?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1013d26c705f2a3f9378d944bd863d94f319d36c
Gerrit-Change-Number: 75832
Gerrit-PatchSet: 1
Gerrit-Owner: Rui Zhou
zhourui@huaqin.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-CC: Jinfang Mao
maojinfang@huaqin.corp-partner.google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Rui Zhou
zhourui@huaqin.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Wed, 14 Jun 2023 17:46:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment