Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41624 )
Change subject: drivers/intel/mipi_camera: Add camera power resource to SSDT ......................................................................
Patch Set 24:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41624/24/src/drivers/intel/mipi_cam... File src/drivers/intel/mipi_camera/camera.c:
https://review.coreboot.org/c/coreboot/+/41624/24/src/drivers/intel/mipi_cam... PS24, Line 604: acpigen_write_package(1); : if (config->pr0) : acpigen_emit_namestring(config->pr0); /* External power resource */ : else : acpigen_emit_namestring(POWER_RESOURCE_NAME);
pr0 is set only for the device that does not have it's own power resource and have reference to powe […]
Fixing formatting of the SSDT data in the previous reply
Before moving the power resource to device scope Scope (_SB.PCI0.I2C5) { PowerResource (RCPR, 0x00, 0x0000) { } Device (CAM1) { Name (_PR0, Package (0x01) // _PR0: Power Resources for D0 { RCPR }) } Device (VCM0) { Name (_PR0, Package (0x01) // _PR0: Power Resources for D0 { RCPR }) } }
After moving the power resource to device scope Scope (_SB.PCI0.I2C5) { Device (CAM1) { PowerResource (RCPR, 0x00, 0x0000) { } Name (_PR0, Package (0x01) // _PR0: Power Resources for D0 { RCPR }) } Device (VCM0) { Name (_PR0, Package (0x01) // _PR0: Power Resources for D0 { ^CAM1.RCPR }) } }