Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41247 )
Change subject: soc/amd/common/block/lpc: Add lpc_initialize_spi_bar() ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41247/3/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/lpc.h:
https://review.coreboot.org/c/coreboot/+/41247/3/src/soc/amd/common/block/in... PS3, Line 195: lpc_initialize_spi_bar
Why are there two ways of setting the spi base? How about dropping the base param and renaming this […]
I kept it this way so that the existing callers can just use lpc_initialize_spi_bar() to do the same action as being done right now. If you think having lpc_enable_spi_rom() instead of this function is cleaner, I can update this. I had started out with lpc_enable_spi_rom(), but then switched to lpc_initialize_spi_bar() when actually updating the callers.