Attention is currently required from: Subrata Banik, Maulik V Vaghela, Selma Bensaid, Paul Menzel, Tim Wawrzynczak. Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61839 )
Change subject: util/cbmem: Keep original Total Time calculation when no negative timestamps ......................................................................
Patch Set 6:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61839/comment/5789f752_5fef83e4 PS5, Line 9: "Total time" calculation changed after CL 59555 to include : "1st timestamp" value in the calculation. This patch restores : original Total Time calculation where "1st timetamp" is : subtracted from "jumping to kernel". If pre CPU reset timestamps : are added (negative timestamps), "Total time" calculation still : includes the pre-reset time as expected.
Reflow for 72 characters per line?
Done
https://review.coreboot.org/c/coreboot/+/61839/comment/a98d72ea_c5d46cef PS5, Line 35: TEST=Boot to OS, check cbmem -t
Please add the board you go the timestamps from.
Done
File util/cbmem/cbmem.c:
https://review.coreboot.org/c/coreboot/+/61839/comment/4bd5915d_e09c828d PS5, Line 648: prev_stamp = tst_p->base_time;
If one branch requires brackets, all branches do.
Done