Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40234 )
Change subject: drivers/ipmi: Add IPMI KCS support in romstage ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40234/5/src/drivers/ipmi/ipmi_kcs_o... File src/drivers/ipmi/ipmi_kcs_ops_premem.c:
https://review.coreboot.org/c/coreboot/+/40234/5/src/drivers/ipmi/ipmi_kcs_o... PS5, Line 34: void ipmi_kcs_premem_init(const u16 port, const u16 device) This function should return a status. If the status is good, caller will proceed with BMC interactions (in romstage). If the status is not good, caller should skip BMC interaction in romstage, and try to test if BMC is up in ramstage. The principle is that if BMC is up, great we can do lots of things. But if BMC is not up, we manage to boot with reduced functionality.
https://review.coreboot.org/c/coreboot/+/40234/5/src/drivers/ipmi/ipmi_kcs_o... PS5, Line 37: struct ipmi_selftest_rsp selftestrsp; This needs to be zero initialized. There is a chance that BMC is not booted up to respond to BMC self test IPMI command till bmc_boot_timeout.