Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42668 )
Change subject: sb/intel/i82801ix/fadt.c: Use acpi.h definitions ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/42668/1/src/southbridge/intel/i8280... File src/southbridge/intel/i82801ix/fadt.c:
https://review.coreboot.org/c/coreboot/+/42668/1/src/southbridge/intel/i8280... PS1, Line 70: fadt->x_pm1b_evt_blk.space_id = 0; setting all fields to zero is valid in ACPI and marks it as unused. as FADT is memset anyway, should we 1: drop it? 2: drop it and add a comment that it's unused? 3: initialize all fields to 0?