Pablo Stebler has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42373 )
Change subject: mainboard/hp: Add ProBook 6360b ......................................................................
Patch Set 6:
(5 comments)
https://review.coreboot.org/c/coreboot/+/42373/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42373/2//COMMIT_MSG@27 PS2, Line 27: TPM
Does SeaBIOS show any options to configure the TPM?
Yes
https://review.coreboot.org/c/coreboot/+/42373/2/src/mainboard/hp/snb_ivb_la... File src/mainboard/hp/snb_ivb_laptops/variants/6360b/gpio.c:
PS2:
Where does this come from? Ideally, you would want to use autoport to generate this file
Autoport
https://review.coreboot.org/c/coreboot/+/42373/2/src/mainboard/hp/snb_ivb_la... File src/mainboard/hp/snb_ivb_laptops/variants/6360b/hda_verb.c:
PS2:
Where does this come from?
Autoport
https://review.coreboot.org/c/coreboot/+/42373/2/src/mainboard/hp/snb_ivb_la... File src/mainboard/hp/snb_ivb_laptops/variants/6360b/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42373/2/src/mainboard/hp/snb_ivb_la... PS2, Line 22: device pci 1c.0 on end # PCIe Port #1
Note that the vendor firmware can swap the PCIe root port functions, you can check for that by looki […]
I have checked again when running coreboot and the values are right.
https://review.coreboot.org/c/coreboot/+/42373/2/src/mainboard/hp/snb_ivb_la... PS2, Line 38: register "ec_data_port" = "0x60" : register "ec_cmd_port" = "0x64" : register "ec_ctrl_reg" = "0xca" : register "ec_fan_ctrl_value" = "0x6e" : device pnp ff.1 off end
Hrm. Seems to be the same as the other Cougar Point boards. […]
Initially I used the same value for `ec_fan_ctrl_value` as 8460p and 2560p but the fan was always on. Now that's only the case after a cold boot. There is a script to find the good values for the ec: https://doc.coreboot.org/mainboard/hp/hp_kbc1126_laptops.html but it did not work as is (not sure exactly why, that's my first time using radare2) so I had to find them manually.