Attention is currently required from: Alexander Couzens, Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Michał Żygowski.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80610?usp=email )
Change subject: mb/lenovo/m900_tiny: add board
......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/lenovo/m900_tiny/include/gpio.h:
https://review.coreboot.org/c/coreboot/+/80610/comment/43f88cf6_8d3e2286 :
PS1, Line 9: st
I know it's a common pattern in other skylake boards, but can you move this to a .c file?
https://review.coreboot.org/c/coreboot/+/80610/comment/aeb96a7e_353ccc2f :
PS1, Line 17: static const struct pad_config gpio_table[] = {
Same
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80610?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6786e068ec03c8bf243e1767cd7b9d50512ea77f
Gerrit-Change-Number: 80610
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Comment-Date: Sun, 18 Feb 2024 17:15:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment