Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34560 )
Change subject: soc/nvidia/tegra124: Correct bitwise operation
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34560/1/src/soc/nvidia/tegra124/sor...
File src/soc/nvidia/tegra124/sor.c:
https://review.coreboot.org/c/coreboot/+/34560/1/src/soc/nvidia/tegra124/sor...
PS1, Line 351: reg_val &= ~(APBDEV_PMC_IO_DPD2_REQ_LVDS_ON ||
That logical or is suspicious...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34560
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8c0ea5a58e25b3b58ed82caba20f8e49a30fb68
Gerrit-Change-Number: 34560
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 24 Jul 2019 22:11:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment