Attention is currently required from: Tarun Tuli, Reka Norman, Jimmy Su, Eric Lai.
Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74728 )
Change subject: mb/google/nissa/var/craask: avoid camera LED blinking during boot
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Please describe the D15 in VCM, also if we enable D15 in VCM, can that remove from the sensor side?
Hi Jimmy,
Base on this CL, we remove D15 related settings and "ACPI_DEVICE_SLEEP_D3_COLD" in VCM, rear camera privacy LED won't blink during system boot to OS, and rear camera looks work normally.
Could you help to review/test it at your side?
Thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74728
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78ed5efe1e2c071d817c1e0455271886e89e63c7
Gerrit-Change-Number: 74728
Gerrit-PatchSet: 1
Gerrit-Owner: Jimmy Su
jimmy.su@intel.com
Gerrit-Reviewer: Jimmy Su
jimmy.su@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andy Yeh
andy.yeh@intel.com
Gerrit-CC: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-CC: Tian Shu Qiu
tian.shu.qiu@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Jimmy Su
jimmy.su@intel.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 26 Apr 2023 09:06:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment