Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31682 )
Change subject: driver/intel/ish: add ish chip driver support
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/31682/4/src/drivers/intel/ish/ish.c
File src/drivers/intel/ish/ish.c:
https://review.coreboot.org/#/c/31682/4/src/drivers/intel/ish/ish.c@46
PS4, Line 46: acpigen_pop_len(); /* Device */
Not required at all, or not required because I am only using one acpigen_write_(scope|device)? […]
Not required because you just need scope and not device.
https://review.coreboot.org/#/c/31682/4/src/drivers/intel/ish/ish.c@72
PS4, Line 72: .write_acpi_tables = pci_rom_write_acpi_tables,
This won't be required as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31682
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id8be986185282521aee574027503eaf8968e1508
Gerrit-Change-Number: 31682
Gerrit-PatchSet: 5
Gerrit-Owner: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: rushikesh s kadam
rushikesh.s.kadam@intel.com
Gerrit-Comment-Date: Mon, 04 Mar 2019 18:00:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jett Rink
jettrink@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment