Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee...
PS3, Line 345: Method (_ON, 0, Serialized) /* VCPR_ON_: VCM Power On */
What happens if one does the following sequence: […]
Is that something the kernel might try to do? If so, then no, this won't work.
If that needs to happen, one way I can think of is to have both power resources utilize the same 'STA' Name; if we do that, then the sequence you state above should work, because STA will still be 1 after #3, and so the sensor & the VCM would still remain powered.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45159
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id51c98e42c5f20e231d8096c9d2d98deebc7c968
Gerrit-Change-Number: 45159
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Kang
daniel.h.kang@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Bingbu Cao
bingbu.cao@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tomasz Figa
tfiga@google.com
Gerrit-Comment-Date: Wed, 30 Sep 2020 15:12:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tomasz Figa
tfiga@google.com
Gerrit-MessageType: comment