Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31752 )
Change subject: device/pci: Rewrite PCI MMCONF with symbol reference ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/#/c/31752/4/src/include/device/pci_mmio_cfg.h File src/include/device/pci_mmio_cfg.h:
https://review.coreboot.org/#/c/31752/4/src/include/device/pci_mmio_cfg.h@27 PS4, Line 27: 2 sizeof(uint16_t)
https://review.coreboot.org/#/c/31752/4/src/include/device/pci_mmio_cfg.h@28 PS4, Line 28: 4 sizeof(uint32_t)
https://review.coreboot.org/#/c/31752/4/src/include/device/pci_mmio_cfg.h@36 PS4, Line 36: dev I assume dev is encoded to have the 12 lower bits cleared? It's kinda subtle. Maybe add a comment or use an inline helper function to return the address and have a single comment there?
https://review.coreboot.org/#/c/31752/4/src/include/device/pci_mmio_cfg.h@65 PS4, Line 65: > just divide by sizeof(uint16_t) and sizeof(uint32_t) below?