Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43890 )
Change subject: mb/purism/librem_skl: Relocate devicetree settings ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/43890/2/src/mainboard/purism/librem... File src/mainboard/purism/librem_skl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43890/2/src/mainboard/purism/librem... PS2, Line 189: device pci 1c.0 on end # PCI Express Port 1 see below, this can be disabled then
https://review.coreboot.org/c/coreboot/+/43890/2/src/mainboard/purism/librem... PS2, Line 195: # FIXME: This seems specific to Librem 15
guys, wait... […]
see CB:35985, CB:36702, CB:36651 ;; rp 5 must be enabled
https://review.coreboot.org/c/coreboot/+/43890/3/src/mainboard/purism/librem... File src/mainboard/purism/librem_skl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43890/3/src/mainboard/purism/librem... PS3, Line 189: on off, see discussion on coalescing; should be done in another commit, though
https://review.coreboot.org/c/coreboot/+/43890/3/src/mainboard/purism/librem... PS3, Line 193: off do not change this from on, see discussion on coalescing
https://review.coreboot.org/c/coreboot/+/43890/3/src/mainboard/purism/librem... PS3, Line 195: # FSP coalescing moves this to RP 1 remove that comment; one does not need to care about coalescing here since devtree reflects the reset state