Attention is currently required from: Yu-Ping Wu.
Dinesh Gehlot has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/83686?usp=email )
Change subject: src: Enforce CSE sync with pertinent GBB flag ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83686/comment/5105fd91_fce9491d?usp... : PS1, Line 13: CB
`CL` […]
Acknowledged
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/83686/comment/0461b9fc_19a0adc6?usp... : PS1, Line 776: - CSE Update not required
This condition is not handled here, so please either move the condition here, or remove this line of […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/83686/comment/8ff70742_48038e7c?usp... : PS1, Line 1068: if (is_cse_sync_enforced()) {
Is this supposed to be called only if `cse_compare_sub_part_version` returns 0 (as we're doing in th […]
The parent function `is_cse_fw_update_required()` determines if cse sync is needed, if yes then it displays `ealry sign of life screen`. At this particular point, we are not worried if its a downgrade, upgrade or a forced cse sync. So first we verify if `is_cse_sync_enforced()` is true. If so, there's no need to compare CSE versions.
However, during the CSE sync process, we assess if it's a downgrade or upgrade by comparing the stored RO and CBFS CSE versions. If the versions match (ret == 0), we then check the possibility of an enforced CSE sync.