Attention is currently required from: Arthur Heymans, Felix Held, Fred Reitberger, Jason Glenesk, Jérémy Compostella, Karthik Ramasubramanian, Martin L Roth, Matt DeVillier.
Yu-Ping Wu has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83594?usp=email )
Change subject: soc/amd/psp_verstage: Add -Oz flag for clang
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83594/comment/7b971ee2_99415d57?usp... :
PS1, Line 9: We have never intended to build ARM verstage with clang (see CB:69701).
@yupingso@google.com, Can you please try -Oz compiler optimization flag here - https://chromium. […]
The `-Oz` flag can solve the build issue. Guybrush has 148K `PSP_SRAM_SIZE` and 40K `PSP_VERSTAGE_STACK_SIZE`, leaving 108K for verstage plus the transfer buffer. The transfer buffer takes about 27K, so verstage must be less than 81K.
Some statistics of verstage size (from `_everstage - _verstage` in GOOGLE_GUYBRUSH/cbfs/fallback/verstage.map):
- gcc: 67K
- clang without `-Oz`: 81K
- clang with `-Oz`: 76K
Re-purposed this patch to add the `-Oz` flag as suggested.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83594?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I033458556986ade88fb8e68499b632deae4dd419
Gerrit-Change-Number: 83594
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 23 Jul 2024 08:06:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com